feat: History V2 - event details with summary#1104
feat: History V2 - event details with summary#1104adhityamamallan merged 11 commits intocadence-workflow:masterfrom
Conversation
003675e to
81499a7
Compare
There was a problem hiding this comment.
Pull request overview
This PR implements a new history details view with summary functionality for workflow events. It introduces a tabbed interface to display event details with the ability to show a summary tab that aggregates key fields from multiple events in a group.
- Adds new reusable components for rendering event details in panels and groups with support for custom rendering configurations
- Implements a tabbed group details view with optional summary tab showing aggregated information
- Updates event group expansion behavior to expand/collapse all events in a group together
Reviewed changes
Copilot reviewed 17 out of 17 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
workflow-history-panel-details-entry/ |
New component for rendering individual detail entries with support for custom value components and group/single entry types |
workflow-history-group-details/ |
New component providing tabbed interface for viewing event details with summary and per-event tabs |
workflow-history-event-details/ |
New component for organizing event details into panels and standard details sections |
workflow-history-grouped-table.tsx |
Updated to pass groupId instead of discarding it, enabling summary tab identification |
workflow-history-event-group/ |
Enhanced to generate event details, manage group expansion state, and render the new group details component |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 17 out of 17 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
src/views/workflow-history-v2/workflow-history-event-group/tests/workflow-history-event-group.test.tsx:223
- The test "calls toggleIsEventExpanded when panel is toggled" (line 207) appears to test the old behavior where only the first event was toggled. However, based on the PR description, the expansion logic was fixed to expand/collapse all events in a group. This test should be updated to verify that
toggleIsEventExpandedis called for all events when the panel is toggled, not just the first one.
Consider updating the test to:
- Use a multi-event group
- Verify that
toggleIsEventExpandedis called once for each event in the group
it('calls toggleIsEventExpanded when panel is toggled', async () => {
const eventGroup: HistoryEventsGroup = {
...mockActivityEventGroupWithMetadata,
events: [scheduleActivityTaskEvent],
};
const toggleIsEventExpanded = jest.fn();
const { user } = setup({ eventGroup, toggleIsEventExpanded });
// Click on the header content to toggle the panel
const headerLabel = screen.getByText('Mock event');
await user.click(headerLabel);
expect(toggleIsEventExpanded).toHaveBeenCalledWith(
scheduleActivityTaskEvent.eventId
);
});
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...flow-history-v2/workflow-history-event-group/__tests__/workflow-history-event-group.test.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-details/workflow-history-event-details.tsx
Outdated
Show resolved
Hide resolved
...-history-v2/workflow-history-event-details/__tests__/workflow-history-event-details.test.tsx
Outdated
Show resolved
Hide resolved
...flow-history-v2/workflow-history-event-group/__tests__/workflow-history-event-group.test.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-details/workflow-history-event-details.tsx
Outdated
Show resolved
Hide resolved
...low-history-v2/workflow-history-panel-details-entry/workflow-history-panel-details-entry.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
7c436d7 to
0e28730
Compare
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 19 out of 19 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...flow-history-v2/workflow-history-event-group/__tests__/workflow-history-event-group.test.tsx
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
src/views/workflow-history-v2/workflow-history-event-group/workflow-history-event-group.tsx
Outdated
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
|
LGTM to me, @adhityamamallan let's follow-up on:
|
Sure thing, I would like to discuss these too.
We're not actually showing the retry policy in a panel 😅 |
Summary
Test plan
Unit tests + ran locally.
Pending events
On narrow screens
Rendering a single details entry in a panel (just an example, this is not actually part of the PR)
Rendering a details entry group in a panel (just an example, this is not actually part of the PR)