feat: Add retry attempt to summary fields for history events#1105
Merged
adhityamamallan merged 5 commits intocadence-workflow:masterfrom Dec 3, 2025
Merged
Conversation
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances workflow history event summaries by adding retry attempt information and improving configurability of summary field display and labeling.
- Adds conditional field hiding via
shouldHidefunction in parser config - Adds custom tooltip label support via
tooltipLabelproperty - Displays retry attempts in summary when attempts > 0, with a retry icon
- Updates timeout icon from stopwatch to hourglass for better visual representation
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/views/workflow-history/workflow-history-event-summary/workflow-history-event-summary.types.ts | Adds shouldHide and tooltipLabel properties to WorkflowHistoryEventSummaryFieldParser type |
| src/views/workflow-history/workflow-history-event-summary/helpers/get-history-event-summary-items.ts | Implements conditional field hiding and custom tooltip label logic |
| src/views/workflow-history/workflow-history-event-summary/helpers/tests/get-history-event-summary-items.test.ts | Adds test coverage for shouldHide and tooltipLabel functionality |
| src/views/workflow-history/config/workflow-history-event-summary-field-parsers.config.ts | Configures retry icon with conditional hiding and updates timeout icon |
| src/views/workflow-history/helpers/get-history-group-from-events/get-single-event-group-from-events.ts | Adds attempt to summary fields for workflow execution started events |
| src/views/workflow-history/helpers/get-history-group-from-events/get-decision-group-from-events.ts | Adds attempt to summary fields for decision task events |
| src/views/workflow-history/helpers/get-history-group-from-events/get-activity-group-from-events.ts | Adds attempt to summary fields for activity task events |
| src/views/workflow-history/helpers/get-history-group-from-events/tests/get-single-event-group-from-events.test.ts | Updates test expectations to include attempt field |
| src/views/workflow-history/helpers/get-history-group-from-events/tests/get-decision-group-from-events.test.ts | Updates test expectations and adds test for pending decision start events |
| src/views/workflow-history/helpers/get-history-group-from-events/tests/get-activity-group-from-events.test.ts | Updates test expectations to include attempt field |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
...ory/workflow-history-event-summary/helpers/__tests__/get-history-event-summary-items.test.ts
Show resolved
Hide resolved
...iews/workflow-history/workflow-history-event-summary/workflow-history-event-summary.types.ts
Show resolved
Hide resolved
Assem-Uber
reviewed
Dec 3, 2025
...iews/workflow-history/workflow-history-event-summary/workflow-history-event-summary.types.ts
Show resolved
Hide resolved
...s/workflow-history/workflow-history-event-summary/helpers/get-history-event-summary-items.ts
Show resolved
Hide resolved
src/views/workflow-history/config/workflow-history-event-summary-field-parsers.config.ts
Show resolved
Hide resolved
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Assem-Uber
approved these changes
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
Unit tests + ran locally.
Actual case
Hypothetical case where we override the label for "attempt/retryAttempt" in the event summary