Skip to content

feat: Add retry attempt to summary fields for history events#1105

Merged
adhityamamallan merged 5 commits intocadence-workflow:masterfrom
adhityamamallan:add-retries-to-summary-fields
Dec 3, 2025
Merged

feat: Add retry attempt to summary fields for history events#1105
adhityamamallan merged 5 commits intocadence-workflow:masterfrom
adhityamamallan:add-retries-to-summary-fields

Conversation

@adhityamamallan
Copy link
Member

@adhityamamallan adhityamamallan commented Dec 3, 2025

Summary

  • Add "attempt" to summary fields
  • Allow conditionally hiding summary details
  • Hide "attempt" from summary details in History V1
  • Support custom tooltip labels for summary details
  • (unrelated) Update the icon for timeouts from a stopwatch to an hourglass

Test plan

Unit tests + ran locally.

Actual case

Screenshot 2025-12-03 at 11 18 50

Hypothetical case where we override the label for "attempt/retryAttempt" in the event summary

Screenshot 2025-12-03 at 10 33 33

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enhances workflow history event summaries by adding retry attempt information and improving configurability of summary field display and labeling.

  • Adds conditional field hiding via shouldHide function in parser config
  • Adds custom tooltip label support via tooltipLabel property
  • Displays retry attempts in summary when attempts > 0, with a retry icon
  • Updates timeout icon from stopwatch to hourglass for better visual representation

Reviewed changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/views/workflow-history/workflow-history-event-summary/workflow-history-event-summary.types.ts Adds shouldHide and tooltipLabel properties to WorkflowHistoryEventSummaryFieldParser type
src/views/workflow-history/workflow-history-event-summary/helpers/get-history-event-summary-items.ts Implements conditional field hiding and custom tooltip label logic
src/views/workflow-history/workflow-history-event-summary/helpers/tests/get-history-event-summary-items.test.ts Adds test coverage for shouldHide and tooltipLabel functionality
src/views/workflow-history/config/workflow-history-event-summary-field-parsers.config.ts Configures retry icon with conditional hiding and updates timeout icon
src/views/workflow-history/helpers/get-history-group-from-events/get-single-event-group-from-events.ts Adds attempt to summary fields for workflow execution started events
src/views/workflow-history/helpers/get-history-group-from-events/get-decision-group-from-events.ts Adds attempt to summary fields for decision task events
src/views/workflow-history/helpers/get-history-group-from-events/get-activity-group-from-events.ts Adds attempt to summary fields for activity task events
src/views/workflow-history/helpers/get-history-group-from-events/tests/get-single-event-group-from-events.test.ts Updates test expectations to include attempt field
src/views/workflow-history/helpers/get-history-group-from-events/tests/get-decision-group-from-events.test.ts Updates test expectations and adds test for pending decision start events
src/views/workflow-history/helpers/get-history-group-from-events/tests/get-activity-group-from-events.test.ts Updates test expectations to include attempt field

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan changed the title feat: Add "retries" to summary fields for history events feat: Add retry attempt to summary fields for history events Dec 3, 2025
Signed-off-by: Adhitya Mamallan <adhitya.mamallan@uber.com>
@adhityamamallan adhityamamallan merged commit a5ae89a into cadence-workflow:master Dec 3, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants