fix: Stop failover history from looping when reaching the end of results#1113
Merged
c-warren merged 4 commits intocadence-workflow:masterfrom Dec 11, 2025
Merged
Conversation
davidporter-id-au
approved these changes
Dec 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When fetching failover history and reaching the end of results (a response of
nextPageToken: "") the page would attempt to load the next page of results. An empty token/undefined token is assumed to be the first page by the server, which resulted in an infinite loop of results.For a domain with no results, this exhibited as an infinite loading screen:
Screen.Recording.2025-12-10.at.13.09.10.mov
For a domain with some results, this exhibited as out of order results + an infinite scroll:
Change
Tanstack already handles this by allowing a different definition of the initial parameter (in our case an empty string) and the request for subsequent pages (the nextPageToken from the response). This update ensures that the nextPageToken is only populated if it is a non-empty string.
For a domain with no results:
Screen.Recording.2025-12-10.at.13.13.36.mov
For a domain with some results:
