Introduce VSCode Remote Containers usage#513
Merged
3vilhamster merged 4 commits intomasterfrom Jun 14, 2023
Merged
Conversation
|
|
Contributor
Author
|
I guess I'll need to add HowTo for local development and local execution with docker-compose. |
dkrotx
approved these changes
Jun 12, 2023
…d updated Dockerfile to ensure we do not modify lock file during building container
gazi-yestemirova
pushed a commit
to gazi-yestemirova/cadence-web
that referenced
this pull request
Jun 14, 2023
* Downgrading locks with a proper npm * Introduce .devcontainer for dockerize development using VSCode * make docker-compose up start local server by default * updated contributing, readme guides with link to Remove containers and updated Dockerfile to ensure we do not modify lock file during building container
gazi-yestemirova
added a commit
that referenced
this pull request
Jun 15, 2023
* Show worflow activity details in a compact modal window * Introduce VSCode Remote Containers usage (#513) * Downgrading locks with a proper npm * Introduce .devcontainer for dockerize development using VSCode * make docker-compose up start local server by default * updated contributing, readme guides with link to Remove containers and updated Dockerfile to ensure we do not modify lock file during building container --------- Co-authored-by: Ilya Ozherelyev <iozherelyev@gmail.com>
Merged
Member
- "lockfileVersion": 2,
+ "lockfileVersion": 1,huh. yeah, dunno how that 2 happened with what should be npm v6: https://docs.npmjs.com/cli/v9/configuring-npm/package-lock-json#lockfileversion thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce docker-compose and .devcontainers so that developers can work in a dockerized environment with a proper node version.
Previously, local development required usage of nvm which does not provide proper isolation of npm and dependencies see #512
So now dockerized development should be the preferred way.
Due to a bug in nvm lock file is generated with a different npm version.
In packages.json we define node requirements:
"engines": { "node": "14.19.3", "npm": "6.14.17" },
so whenever you use nvm use 14.19.3 nvm points node to a proper version, while npm is actually 9+
This somehow bypasses the constraints.
I've used dockerized version of node to use the proper npm version and ran npm install to update the lock file.
In the next PR, I'll introduce .devcontainers which will allow all developers use dockerized node version with VSCode.