Add ChronosPeriod which returns Chronos instances from DatePeriod #472
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
othercorey
force-pushed
the
chronos-period
branch
from
1493a22 to
7ca219b
Compare
othercorey
force-pushed
the
chronos-period
branch
5 times, most recently
from
d0eae94 to
07c3f0c
Compare
othercorey
force-pushed
the
chronos-period
branch
from
07c3f0c to
ee38f12
Compare
othercorey
commented
Jun 17, 2025
| { | ||
| /** @var \Iterator<int, \DateTimeInterface> $iterator */ | ||
| $iterator = $period->getIterator(); | ||
| $this->iterator = $iterator; |
Member
Author
There was a problem hiding this comment.
We assume getIterator() actually returns an InternalIterator even though IteratorAggregate is typed as Traversable.
ADmad
approved these changes
Jun 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is really just an iterator converter, but I don't think anything else is needed.