Skip to content

Fix renaming column with Extra info set #2275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MasterOdin merged 2 commits into from
May 20, 2024
Merged

Fix renaming column with Extra info set #2275

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef0f41
Fix renaming column with Extra info set for mysql
MasterOdin May 20, 2024
5506072
Merge branch '0.x' into fix-rename-column-mysql
MasterOdin May 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Phinx/Db/Adapter/MysqlAdapter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -574,7 +574,7 @@ protected function getRenameColumnInstructions(string $tableName, string $column

return true;
});
$extra = implode(' ', $extras);
$extra = ' ' . implode(' ', $extras);

if (($row['Default'] !== null)) {
$extra .= $this->getDefaultValueDefinition($row['Default']);
Expand Down
13 changes: 13 additions & 0 deletions tests/Phinx/Db/Adapter/MysqlAdapterTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -927,6 +927,19 @@ public function testRenameColumn()
$this->assertTrue($this->adapter->hasColumn('t', 'column2'));
}

public function testRenameNonNullColumnWithExtra()
{
// Extra = "AUTO_INCREMENT" for the id column
$table = new Table('t', [], $this->adapter);
$table->save();
$this->assertTrue($this->adapter->hasColumn('t', 'id'));
$this->assertFalse($this->adapter->hasColumn('t', 'new_id'));

$table->renameColumn('id', 'new_id')->save();
$this->assertFalse($this->adapter->hasColumn('t', 'id'));
$this->assertTrue($this->adapter->hasColumn('t', 'new_id'));
}

public function testRenameColumnPreserveComment()
{
$table = new Table('t', [], $this->adapter);
Expand Down