fix: chunk long Android recordings#617
Merged
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android
adb shell screenrecordhas a hard 180s platform limit. Long Androidrecord start/record stopsessions now rotate into multiple MP4 chunks before that limit, return structuredchunksmetadata, and print readable numbered chunk paths for human stdout.This keeps the existing adb recorder instead of adding a MediaProjection helper app, and avoids extra chunk-boundary file-stability polling so the capture gap is as small as practical. Touch overlay burn-in remains available for single-chunk Android recordings; chunked Android recordings return raw chunks plus gesture telemetry with an explicit overlay warning.
Closes #615
Touched-file count: 11. Scope stayed within the
record/tracecommand family plus CLI output/help tests.Validation
Passed
pnpm format,pnpm check:quick, focused record/output tests, Android provider recording scenario tests, CLI help assertions,pnpm test:smoke,pnpm check:unitoutside the sandbox, andgit diff --check. The sandboxed aggregate unit run failed on environment permissions for loopback listeners and Swift subprocess checks, then passed when rerun outside the sandbox.