Skip to content

Fix nullable/nonnull annotations #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
Dec 10, 2020
Merged

Fix nullable/nonnull annotations #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions android/app/src/main/java/suraj/tiwari/reactnativefbads/BannerViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,9 @@
package suraj.tiwari.reactnativefbads;


import android.support.annotation.Nullable;
import androidx.annotation.Nullable;

import com.facebook.ads.AdSize;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.bridge.ReadableMap;
import com.facebook.react.common.MapBuilder;
import com.facebook.react.uimanager.SimpleViewManager;
import com.facebook.react.uimanager.ThemedReactContext;
Expand Down
7 changes: 5 additions & 2 deletions android/app/src/main/java/suraj/tiwari/reactnativefbads/NativeAdViewManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
package suraj.tiwari.reactnativefbads;

import android.content.Context;
import android.support.annotation.Nullable;
import android.util.Log;
import android.view.View;

import androidx.annotation.NonNull;
import androidx.annotation.Nullable;

import com.facebook.ads.NativeAdsManager;
import com.facebook.react.bridge.ReactContext;
import com.facebook.react.common.MapBuilder;
Expand All @@ -22,8 +24,9 @@ public String getName() {
return NAME;
}

@NonNull
@Override
protected NativeAdView createViewInstance(ThemedReactContext reactContext) {
protected NativeAdView createViewInstance(@NonNull ThemedReactContext reactContext) {
return new NativeAdView(reactContext);
}

Expand Down