Skip to content

fix: support for iOS 14+ with setAdvertiserTrackingEnabled; remove rectangle banner on iOS#280

Merged
thymikee merged 11 commits intomasterfrom
ios-14-rectangle-banner
Feb 8, 2021
Merged

fix: support for iOS 14+ with setAdvertiserTrackingEnabled; remove rectangle banner on iOS#280
thymikee merged 11 commits intomasterfrom
ios-14-rectangle-banner

Conversation

@TMaszko
Copy link
Copy Markdown
Collaborator

@TMaszko TMaszko commented Feb 8, 2021

Summary

In this PR:

  • removed rectangle banner on ios
  • added support for ios 14+ by implementing setAdvertiserTrackingEnabled method
  • added readme for setAdvertiserTrackingEnabled method

Test plan

  1. Open iOS simulator/device with ios 14+
  2. Give app tracking permission
  3. Check all types of ads -> they should be visible

@TMaszko TMaszko requested review from mrousavy and thymikee February 8, 2021 10:59
@TMaszko TMaszko closed this Feb 8, 2021
@TMaszko TMaszko reopened this Feb 8, 2021
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
Copy link
Copy Markdown
Collaborator

@mrousavy mrousavy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - but doesn't the native android SDK also provide the personalization enable/disable func?

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>

> Requires iOS 14. On Android and iOS versions below 14, this will always be no-op.

### setAdvertiserTrackingEnabled
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a clear notice that FB won't display adds when this is not set to true

@TMaszko
Copy link
Copy Markdown
Collaborator Author

TMaszko commented Feb 8, 2021

@mrousavy hmm I did this upgrade according to this guide https://developers.facebook.com/docs/audience-network/guides/advertising-tracking-enabled. I haven't seen anything about Android :(.

Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
@thymikee thymikee changed the title Removed rectangle banner on ios, support for ios 14+ fix: support for iOS 14+ with setAdvertiserTrackingEnabled; remove rectangle banner on iOS Feb 8, 2021
@thymikee thymikee merged commit fb95468 into master Feb 8, 2021
@thymikee thymikee deleted the ios-14-rectangle-banner branch February 8, 2021 12:58
@bliang
Copy link
Copy Markdown

bliang commented Mar 13, 2021

How were you able to get around the requirement for:

[!] CocoaPods could not find compatible versions for pod "FBSDKShareKit":
  In snapshot (Podfile.lock):
    FBSDKShareKit (= 5.8, = 5.8.0)

  In Podfile:
    react-native-fbsdk (from `../node_modules/react-native-fbsdk`) was resolved to 3.0.0, which depends on
      react-native-fbsdk/Share (= 3.0.0) was resolved to 3.0.0, which depends on
        FBSDKShareKit (~> 8.1)


You have either:
 * changed the constraints of dependency `FBSDKShareKit` inside your development pod `react-native-fbsdk`.
   You should run `pod update FBSDKShareKit` to apply changes you've made.

Correct if I am wrong, but this would require react-native-fbsdk 3.0.0 for FBSDK v9.

@mrousavy
Copy link
Copy Markdown
Collaborator

Did you run what the command output suggested?

pod repo update
pod update FBSDKShareKit

@bliang
Copy link
Copy Markdown

bliang commented Mar 13, 2021

@mrousavy I have.

@bliang
Copy link
Copy Markdown

bliang commented Mar 14, 2021

Looks like Podfile.lock needed to be cleared first since it was pinned to a previous version. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants