fix: support for iOS 14+ with setAdvertiserTrackingEnabled; remove rectangle banner on iOS#280
fix: support for iOS 14+ with setAdvertiserTrackingEnabled; remove rectangle banner on iOS#280
setAdvertiserTrackingEnabled; remove rectangle banner on iOS#280Conversation
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
mrousavy
left a comment
There was a problem hiding this comment.
Looks good to me - but doesn't the native android SDK also provide the personalization enable/disable func?
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
…native-fbads into ios-14-rectangle-banner
|
|
||
| > Requires iOS 14. On Android and iOS versions below 14, this will always be no-op. | ||
|
|
||
| ### setAdvertiserTrackingEnabled |
There was a problem hiding this comment.
Let's add a clear notice that FB won't display adds when this is not set to true
|
@mrousavy hmm I did this upgrade according to this guide https://developers.facebook.com/docs/audience-network/guides/advertising-tracking-enabled. I haven't seen anything about Android :(. |
Co-authored-by: Michał Pierzchała <thymikee@gmail.com>
setAdvertiserTrackingEnabled; remove rectangle banner on iOS
|
How were you able to get around the requirement for: Correct if I am wrong, but this would require react-native-fbsdk 3.0.0 for FBSDK v9. |
|
Did you run what the command output suggested? |
|
@mrousavy I have. |
|
Looks like Podfile.lock needed to be cleared first since it was pinned to a previous version. Thanks! |
Summary
In this PR:
setAdvertiserTrackingEnabledmethodsetAdvertiserTrackingEnabledmethodTest plan