feature: Add compression quality prop#130
Merged
Merged
Conversation
retyui
force-pushed
the
feature/retyui/add-compression-quality-prop
branch
from
a8350e5 to
4b612ce
Compare
mateusz1913
suggested changes
Jan 13, 2024
mateusz1913
left a comment
mateusz1913
left a comment
Contributor
There was a problem hiding this comment.
pls implement quality value validation
retyui
force-pushed
the
feature/retyui/add-compression-quality-prop
branch
from
4b612ce to
b1cbe15
Compare
|
Can you add |
retyui
added a commit
that referenced
this pull request
Jan 21, 2024
retyui
added a commit
that referenced
this pull request
Jan 21, 2024
Collaborator
Author
|
@ionflow Thank for letting me know |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Allow to change quality of the resulting image via passing
quality: numberprop. Used the default values without making any breaking changes.Test plan
Example:
Screen.Recording.2024-01-12.at.17.34.36.mov