Skip to content

fix: Restore resizeMode logic after New Arch update#138

Merged
retyui merged 3 commits into
masterfrom
fix/retyui/resizeMode-logic
Feb 22, 2024
Merged

fix: Restore resizeMode logic after New Arch update#138
retyui merged 3 commits into
masterfrom
fix/retyui/resizeMode-logic

Conversation

@retyui

@retyui retyui commented Feb 19, 2024

Copy link
Copy Markdown
Collaborator

Summary

After migration to the New Arch iOS resizeMode was affected and doesn't work properly

Test plan

example of resizeMode: 'stretch'

Before (doesn't work) After (fixed)

@retyui retyui requested a review from mateusz1913 February 19, 2024 17:47
Comment thread ios/RNCImageEditor.mm Outdated
Comment thread ios/RNCImageEditor.mm Outdated
@retyui retyui force-pushed the fix/retyui/resizeMode-logic branch from fffa207 to 3a93a25 Compare February 20, 2024 18:01
@retyui retyui requested a review from mateusz1913 February 20, 2024 18:07
@retyui retyui force-pushed the fix/retyui/resizeMode-logic branch from 01bed3d to d9c6687 Compare February 22, 2024 12:58

@mateusz1913 mateusz1913 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🥳

@retyui retyui merged commit c59e226 into master Feb 22, 2024
@retyui retyui deleted the fix/retyui/resizeMode-logic branch February 25, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants