feat: add hover support to web#3751
Closed
RichardLindhout wants to merge 3 commits intocallstack:mainfrom
web-ridge:hover-support
Closed
feat: add hover support to web#3751RichardLindhout wants to merge 3 commits intocallstack:mainfrom web-ridge:hover-support
RichardLindhout wants to merge 3 commits intocallstack:mainfrom
web-ridge:hover-support
Conversation
lukewalczak
reviewed
Mar 20, 2023
| React.Children.only( | ||
| typeof children === 'function' ? children(state) : children | ||
| ) | ||
| } |
Member
There was a problem hiding this comment.
Please add unit test for introduced changes in styles and rendering the children.
lukewalczak
reviewed
Mar 20, 2023
| ViewStyle, | ||
| } from 'react-native'; | ||
|
|
||
| import Color from 'color'; |
Member
There was a problem hiding this comment.
Suggested change
| import Color from 'color'; | |
| import color from 'color'; |
lukewalczak
reviewed
Mar 20, 2023
| theme, | ||
| rippleColor, | ||
| }); | ||
| const hoverColor = Color(calculatedRippleColor).fade(0.5).rgb().string(); |
Member
There was a problem hiding this comment.
Suggested change
| const hoverColor = Color(calculatedRippleColor).fade(0.5).rgb().string(); | |
| const hoverColor = color(calculatedRippleColor).fade(0.5).rgb().string(); |
|
|
Collaborator
|
Moved to #3909 due to inactivity. Thank you for your contributions, we can pick it up from here! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3749
Test plan
I tested the demo app!
paper-hover.mov