Slider should announce disabled when interacting with #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are only to announce "disabled" if a Slider receives the onHover event and is disabled. Otherwise we do nothing to avoid spamming user with too many redundant messages. Also the Slider should return true as the event has been handled. The docs for this: https://developer.android.com/reference/android/view/View#onHoverEvent(android.view.MotionEvent)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request closes #265
It delivers the overridden
onTouchEventwhich announce the "disabled" state of the Slider if a blind user tries to interact with disabled component.The implementation is simple:
Override the
onTouchEventand check if Slider is already disabled and if theACTION_DOWNwas performed on the Slider.If both conditions are met send the accessibility message saying that "slider disabled" so that user knows that:
It's necessary to react only on the
ACTION_DOWNevent, omitting theACTION_UP, to avoid spamming blind user with too many messages and because a Slider is not a button, and user will most probably try to drag it instead of clicking on it.We allow the
taptoSeekbut it will still fall into theACTION_DOWNcategory.NOTE:
There's no
PerformClick()override, even though the docs suggests to do it. The reason for not implementing it is that there cannot be a click event's reaction on a disabled component, and if it's enabled there's still theonValueChangewhich will announce the newvalueandunits.