fix: use safer in-page swipe lane#631
Merged
Merged
Conversation
Size Report
Startup median (7 runs, lower is better):
Top changed chunks:
|
d402ea1 to
6370caa
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use one consistent in-page swipe preset for native
gesture swipe left|rightand Maestro directional swipes: 15%↔85% horizontally at a lower 65% viewport lane.This keeps in-page swipes away from the iOS edge-navigation zone without shortening the gesture so much that React Native pager/material-tab views stop advancing. Explicit edge-navigation presets (
left-edge/right-edge) remain unchanged.I also tried the more human-like 25%↔75% lane. It failed React Navigation iOS pager flows (
material-top-tabs,tab-view-custom-tab-bar,tab-view-scrollable-tab-bar) because the 50% travel was too short. 15%↔85% was the smallest consistent lane that passed the sensitive flows locally.Validation
pnpm exec vitest run src/__tests__/runtime-interactions.test.ts src/core/__tests__/dispatch-interactions.test.tspnpm buildpnpm check:quickshowcase-material-top-tabs.yml, 15%↔85%: passed, no retriesstack-float-screen-header.yml, rerun of that flow passed in 7.6s