Skip to content

fix(ios): drive gesture pinch via two-finger synthesis (#629) #634

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thymikee merged 1 commit into from
May 31, 2026
+20 −0
Merged

fix(ios): drive gesture pinch via two-finger synthesis (#629) #634

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions ios-runner/AgentDeviceRunner/AgentDeviceRunnerUITests/RunnerTests+Interaction.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,27 @@ extension RunnerTests {
}

func pinch(app: XCUIApplication, scale: Double, x: Double?, y: Double?) -> RunnerInteractionOutcome {
#if os(iOS)
// A coordinate tap+drag is a single-finger gesture: React Native reads it as a pan
// and the pinch scale never changes (#629). Drive the two-finger XCTest synthesis
// path (the same one transformGesture uses) with zero translation/rotation so RN's
// pinch recognizer actually fires.
let frame = interactionRoot(app: app).frame
let centerX = x ?? Double(frame.midX)
let centerY = y ?? Double(frame.midY)
return transformGesture(
app: app,
x: centerX,
y: centerY,
dx: 0,
dy: 0,
scale: scale,
degrees: 0,
durationMs: 300
)
#else
return performCoordinatePinch(app: app, scale: scale, x: x, y: y)
#endif
}

func rotateGesture(app: XCUIApplication, degrees: Double, x: Double?, y: Double?, velocity: Double) -> RunnerInteractionOutcome {
Expand Down
Loading