-
Notifications
You must be signed in to change notification settings - Fork 7
Package cleanup #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
70ca143 to
c66675f
Compare
|
I suggest closing this PR in favor of #6 (and others coming up). |
|
WDYT about moving from both Prettier and ESLint to Biome.js (which is mostly compatible with both of them)? I've committed a config in the host package |
|
I don't have experience with Biome, but I'd be okay with giving it a try. As long as we can have a unified way of formatting and linting across all packages of the repo - my main concern is that some packages would have to be CJS and others ESM, some JS and other TS and there's differences in what runtime APIs (globals) are available in either. In any case, I'd like to close this PR in hopes that we can merge #6 instead 🤞 I'd be happy to merge a PR transitioning to Biome soon after that. |
After #1 I changed my mind 🙈 and don't really see the big advantage of using the react-native eslint config, which removes the need to pin eslint at v8.
I propose these changes to simplify the packages by hoisting common dev-dependencies to the root. It also turned out I didn't have all packages in the workspace referenced in #1.
I ran
eslint --fixandprettier --writeas well.