Skip to content

Conversation

@kraenhansen
Copy link
Collaborator

@kraenhansen kraenhansen commented Apr 17, 2025

After #1 I changed my mind 🙈 and don't really see the big advantage of using the react-native eslint config, which removes the need to pin eslint at v8.

I propose these changes to simplify the packages by hoisting common dev-dependencies to the root. It also turned out I didn't have all packages in the workspace referenced in #1.

I ran eslint --fix and prettier --write as well.

@kraenhansen kraenhansen self-assigned this Apr 17, 2025
@changeset-bot
Copy link

changeset-bot bot commented Apr 17, 2025

⚠️ No Changeset found

Latest commit: 5e15979

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kraenhansen
Copy link
Collaborator Author

I suggest closing this PR in favor of #6 (and others coming up).

@mani3xis
Copy link
Contributor

WDYT about moving from both Prettier and ESLint to Biome.js (which is mostly compatible with both of them)? I've committed a config in the host package

@kraenhansen
Copy link
Collaborator Author

kraenhansen commented Apr 22, 2025

I don't have experience with Biome, but I'd be okay with giving it a try.

As long as we can have a unified way of formatting and linting across all packages of the repo - my main concern is that some packages would have to be CJS and others ESM, some JS and other TS and there's differences in what runtime APIs (globals) are available in either.

In any case, I'd like to close this PR in hopes that we can merge #6 instead 🤞 I'd be happy to merge a PR transitioning to Biome soon after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants