Skip to content

Fix ordered list formatting in README.md#10

Merged
cameron314 merged 1 commit into
cameron314:masterfrom
jplatte:patch-1
Jan 24, 2015
Merged

Fix ordered list formatting in README.md#10
cameron314 merged 1 commit into
cameron314:masterfrom
jplatte:patch-1

Conversation

@jplatte
Copy link
Copy Markdown
Contributor

@jplatte jplatte commented Jan 24, 2015

Have a look at the "rich diff" (document icon in the header of the README.md diff view) instead of the code diff to see how the generated HTML changes.

@cameron314
Copy link
Copy Markdown
Owner

Ah, good catch, thanks!

I think it's the blank line you added (and not the 1s) that makes all the difference, though -- markdown is supposed to accept increasing digits as an ordered list.

I'll gladly accept the pull request if you change the numbers back to sequentially increasing ones (for those that read the README as plain text).

@jplatte
Copy link
Copy Markdown
Contributor Author

jplatte commented Jan 24, 2015

I know the blank line was the important change, just thought only 1s would make editing simpler. I'll change it back if you don't want it.

@jplatte
Copy link
Copy Markdown
Contributor Author

jplatte commented Jan 24, 2015

Okay, I rewrote the commit now (didn't want to have two commits around for this tiny change).

cameron314 added a commit that referenced this pull request Jan 24, 2015
Fix ordered list formatting in README.md
@cameron314 cameron314 merged commit f3a0aba into cameron314:master Jan 24, 2015
@cameron314
Copy link
Copy Markdown
Owner

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants