Skip to content

Added MOODYCAMEL_DELETED_FUNCTION macro (compiling under VS2012 now works)#19

Merged
cameron314 merged 1 commit into
cameron314:masterfrom
jlaumon:master
May 20, 2015
Merged

Added MOODYCAMEL_DELETED_FUNCTION macro (compiling under VS2012 now works)#19
cameron314 merged 1 commit into
cameron314:masterfrom
jlaumon:master

Conversation

@jlaumon
Copy link
Copy Markdown
Contributor

@jlaumon jlaumon commented May 20, 2015

No description provided.

cameron314 added a commit that referenced this pull request May 20, 2015
@cameron314
Merge pull request #19 from jlaumon/master
3a5c3d2 
Added MOODYCAMEL_DELETED_FUNCTION macro (compiling under VS2012 now works)
@cameron314 cameron314 merged commit 3a5c3d2 into cameron314:master May 20, 2015
@cameron314
Copy link
Copy Markdown
Owner

cameron314 commented May 20, 2015

Awesome, looks good.

@cameron314
Copy link
Copy Markdown
Owner

cameron314 commented May 20, 2015

Hmm, wait, the tests don't compile. I'll fix it.

@cameron314
Copy link
Copy Markdown
Owner

cameron314 commented May 20, 2015

I got everything to compile and run. The unit test for exception handling doesn't pass. I'm looking into it.

@cameron314
Copy link
Copy Markdown
Owner

cameron314 commented May 20, 2015

OK, the unit test for exception handling sometimes passes, and sometimes fails. The thing is, that part of the test is not threaded, meaning there's either a compiler bug or I'm invoking undefined behaviour somewhere (otherwise the result of the test should be deterministic).

@cameron314
Copy link
Copy Markdown
Owner

cameron314 commented May 20, 2015

Ah, MOODYCAMEL_NOEXCEPT_CTOR/MOODYCAMEL_NOEXCEPT_ASSIGN were true when they shouldn't have been. Apparently std::is_nothrow_move_constructible and std::is_nothrow_constructible are broken in VS2012 (they yield the right value in VS2013).

cameron314 added a commit that referenced this pull request May 20, 2015
@cameron314
Fixed build and failing unit tests under VS2012 (related to issue #18/…
317a67b 
…pull #19)
@cameron314 cameron314 mentioned this pull request May 20, 2015
Closed
@jlaumon
Copy link
Copy Markdown
Contributor Author

jlaumon commented May 21, 2015

Great! Thanks!
Sorry for letting you do all the hard work.

@cameron314
Copy link
Copy Markdown
Owner

cameron314 commented May 21, 2015

No worries. Might be a good idea to run the tests first next time though :-)

@kdtiankong kdtiankong mentioned this pull request Nov 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jlaumon @cameron314