fix(safari): fix an issue when using startAt.fromLivePosition with directfile content#1842
Open
Florent-Bouisset wants to merge 1 commit into
Open
fix(safari): fix an issue when using startAt.fromLivePosition with directfile content#1842Florent-Bouisset wants to merge 1 commit into
Florent-Bouisset wants to merge 1 commit into
Conversation
…rectfile content The startAt.fromLivePosition was not checking correctly that the wanted position was finite. It would lead to seeking to "Infinity" in some cases. Now the player wait that the media element has duration or seekable proprety defined and finite before calculating the wanted position.
Florent-Bouisset
added
the
bug
|
✅ Automated performance checks have passed on commit DetailsPerformance tests 1st run outputNo significative change in performance for tests:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The startAt.fromLivePosition was not checking correctly that the wanted position was finite. It would lead to seeking to "Infinity" in some cases. Now the player wait that the media element has duration or that the seekable proprety is properly defined and finite before calculating the wanted position.