Skip to content

chore: bump version to fix CVE#274

Merged
niemeyer merged 3 commits into
canonical:mainfrom
upils:vuln-fix
Mar 30, 2026
Merged

chore: bump version to fix CVE#274
niemeyer merged 3 commits into
canonical:mainfrom
upils:vuln-fix

Conversation

@upils
Copy link
Copy Markdown
Collaborator

@upils upils commented Mar 12, 2026

  • Have you signed the CLA?

Bump the minimal go version to 1.25.8, fixing the following vulnerabilities, affecting go 1.24.6:

CVE-2025-68121 (CRITICAL)
CVE-2025-58183 (HIGH)
CVE-2025-61726 (HIGH)
CVE-2025-61728 (HIGH)
CVE-2025-61729 (HIGH)

go 1.24.13 cannot be used as it is not available yet in the snapstore.
go 1.26 cannot be used either as there is no stable snap of it in the snapstore.

govulncheck does not identify any vulnerabilities after this fix.
trivy does not identify any stdlib-related vulnerabilities after this fix.

golangci-lint is also bumped to v2.x to be compatible with go 1.25. To do so, the configuration is migrated to the v2 format, with the minimum amount of changes. Some checks are excluded to avoid unrelated fixes in this PR. They should be re-enabled in a follow-up PR and the code corrected.

Copy link
Copy Markdown
Contributor

@lczyk lczyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

this should also fix #250 since the fix for the problem there has been backported to go1.25.4 golang/go#75775

btw, because of this issue i've been using chisel compiled with go1.26 and i've seen no regressions due to golang version bump

@upils
Copy link
Copy Markdown
Collaborator Author

upils commented Mar 12, 2026

👍

this should also fix #250 since the fix for the problem there has been backported to go1.25.4 golang/go#75775

Correct!

btw, because of this issue i've been using chisel compiled with go1.26 and i've seen no regressions due to golang version bump

Nice to know the path to a future bump to go1.26 is clear!

@upils upils added the Simple Nice for a quick look on a minute or two label Mar 12, 2026
@upils upils requested a review from letFunny March 12, 2026 12:12
Copy link
Copy Markdown
Collaborator

@letFunny letFunny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you for working on it. I think we should create a backlog item to come back and fix the lints in the (near) future.

Comment thread .golangci.yaml Outdated
This was referenced Mar 16, 2026
Copy link
Copy Markdown
Contributor

@niemeyer niemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm merging this since it's about CVEs and has been hanging for a while, but we should talk about what kind of conversation happened to make sure changing the Go version of the project would go smoothly in the places we care about.

Thanks for pushing the fixes.

@niemeyer niemeyer merged commit 9af7a8e into canonical:main Mar 30, 2026
15 checks passed
niemeyer pushed a commit that referenced this pull request Mar 30, 2026
Pin all actions used in workflows with hashes.
This also bumps setup-go and checkout actions version as I expect no breaking
change given how they are used.

Remaining actions not pinned in this PR are pinned or reworked in other PRs (see
#275, #274, #272)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Simple Nice for a quick look on a minute or two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants