fix(CheckboxInput & RadioInput): add Field to expose error help and other props used by Input#1384
Open
kimanhou wants to merge 3 commits into
Open
fix(CheckboxInput & RadioInput): add Field to expose error help and other props used by Input#1384kimanhou wants to merge 3 commits into
kimanhou wants to merge 3 commits into
Conversation
Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
Signed-off-by: Kim Anh Nguyen <4783194+kimanhou@users.noreply.github.com>
2d9629f to
3459de5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Done
CheckboxInputandRadioInputto exposeerror,helpand other props used by Input.This enhancement will allow us to stop using
<Input type="checkbox" />and<Input type="radio" />and only use the dedicated componentsCheckboxInputandRadioInputinstead.QA
Pinging @canonical/react-library-maintainers for a review.
Storybook
To see rendered examples of all react-components, run:
QA in your project
from
react-componentsrun:Install the resulting tarball in your project with:
QA steps
Percy steps