Skip to content

Fix: Non existing cartesi-machine option #476

@brunomenezes

Description

@brunomenezes

🙂 Expected behavior

CLI should not add in the arguments options flags that is non-existing in the cartesi-machine.

🫠 Actual behavior

There is a no-rollup available to configure. It is passed down when running the cartesi build command.

🧪 Minimal test case

using the latest CLI (alpha.34) and having cartesi-machine installed or at least Docker available.

  1. Create a simple Application cartesi create --template=<template_name> <app_name>
  2. cd <app_name>
  3. create a cartesi.toml file
  4. add the following configuration
[machine]
no_rollup=true
  1. Run cartesi build

Code ref: https://github.com/cartesi/cli/blob/prerelease/v2-alpha/apps/cli/src/machine.ts#L111
cartesi.toml test ref: https://github.com/cartesi/cli/blob/prerelease/v2-alpha/apps/cli/tests/unit/config/fixtures/full.toml#L9

✔️ Possible solutions

  1. If it is a mistake remove that option from both code and test references
  2. if it is a typo due to a --no-rollback exist, replace accordingly.

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingcliv2

    Type

    No type
    No fields configured for issues without a type.

    Projects

    Status

    Todo

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions