Improve docstring for approximation_grain in ParallelogramOLF#687
Improve docstring for approximation_grain in ParallelogramOLF#687kennethshsu wants to merge 1 commit intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #687 +/- ##
=======================================
Coverage 85.08% 85.08%
=======================================
Files 85 85
Lines 4896 4896
Branches 629 629
=======================================
Hits 4166 4166
Misses 521 521
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
andyhufford-HARC
left a comment
There was a problem hiding this comment.
First PR Approval. @kennethshsu
|
Can you actually approve it?🙂 |
|
I thought I did approve it. It does say that I have "read-only" permissions and that it requires "at least 1 approving review is required by reviewers with write access". |
|
Let me check on what's going on... |
|
Did you ever resolve the PR? Also I tried to run with the "daily" grain [approximation_grain='D'] and I couldn't get it to work. testing CAS exampleimport chainladder as cl rate_history = pd.DataFrame({ data = pd.DataFrame({ prem_tri = cl.Triangle(data, origin='Year', columns='EarnedPremium') |
Note
Low Risk
Docstring-only change; no functional or behavioral impact.
Overview
Improves the
ParallelogramOLFdocstring by documenting theapproximation_grainparameter, including supported values ('M'monthly,'D'daily) and the effect of daily granularity (leap-year handling when assigning factors to origin periods).Written by Cursor Bugbot for commit b984f80. This will update automatically on new commits. Configure here.