chore(github): remove unwanted MCP toolsets and insiders mode - #14
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
WalkthroughThe pull request updates two GitHub plugin configuration files: the plugin metadata description was shortened to list selected toolsets, the keywords array removed "copilot", and the MCP header replaced wildcard/insiders values with an explicit list of toolsets. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 2✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
🧹 Nitpick comments (2)
github/.mcp.json (1)
8-8: LGTM! Optionally simplify using thedefaultkeyword.The explicit toolset list is correct. As a minor simplification, the
defaultkeyword refers to the default bundle of toolsets (context,issues,pull_requests,repos,users), so the value could be shortened to"default,actions,orgs,labels,notifications,discussions,gists,projects,code_security,secret_protection,dependabot,security_advisories,github_support_docs_search", removing 5 explicitly named entries.♻️ Optional simplification using `default`
- "X-MCP-Toolsets": "context,repos,issues,pull_requests,users,actions,orgs,labels,notifications,discussions,gists,projects,code_security,secret_protection,dependabot,security_advisories,github_support_docs_search" + "X-MCP-Toolsets": "default,actions,orgs,labels,notifications,discussions,gists,projects,code_security,secret_protection,dependabot,security_advisories,github_support_docs_search"Note: invalid or unknown toolsets are silently ignored without error and will not prevent the server from starting, so the explicit list is safe as-is if you prefer the clarity of naming every toolset.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@github/.mcp.json` at line 8, Replace the explicit toolset list in the "X-MCP-Toolsets" value with the shorter form using the default keyword; update the string currently containing "context,repos,issues,pull_requests,users,actions,orgs,labels,notifications,discussions,gists,projects,code_security,secret_protection,dependabot,security_advisories,github_support_docs_search" to use "default" in place of the five entries (context, issues, pull_requests, repos, users) so it becomes "default,actions,orgs,labels,notifications,discussions,gists,projects,code_security,secret_protection,dependabot,security_advisories,github_support_docs_search".github/.claude-plugin/plugin.json (1)
9-9: Consider removing the stale"copilot"keyword.The
copilotandcopilot_spacestoolsets were intentionally excluded from.mcp.json. Keeping"copilot"as a discovery keyword could mislead users into expecting Copilot-specific tooling.♻️ Suggested fix
- "keywords": ["github", "mcp", "issues", "pull-requests", "copilot", "code-security"] + "keywords": ["github", "mcp", "issues", "pull-requests", "code-security"]🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@github/.claude-plugin/plugin.json` at line 9, Remove the stale "copilot" discovery keyword from the keywords array in plugin.json (the entry "keywords": ["github", "mcp", "issues", "pull-requests", "copilot", "code-security"]); update the array to exclude "copilot" so it no longer advertises Copilot tooling and run a quick JSON lint to ensure the file stays valid after editing.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@github/.claude-plugin/plugin.json`:
- Line 9: Remove the stale "copilot" discovery keyword from the keywords array
in plugin.json (the entry "keywords": ["github", "mcp", "issues",
"pull-requests", "copilot", "code-security"]); update the array to exclude
"copilot" so it no longer advertises Copilot tooling and run a quick JSON lint
to ensure the file stays valid after editing.
In `@github/.mcp.json`:
- Line 8: Replace the explicit toolset list in the "X-MCP-Toolsets" value with
the shorter form using the default keyword; update the string currently
containing
"context,repos,issues,pull_requests,users,actions,orgs,labels,notifications,discussions,gists,projects,code_security,secret_protection,dependabot,security_advisories,github_support_docs_search"
to use "default" in place of the five entries (context, issues, pull_requests,
repos, users) so it becomes
"default,actions,orgs,labels,notifications,discussions,gists,projects,code_security,secret_protection,dependabot,security_advisories,github_support_docs_search".
Replace X-MCP-Toolsets "all" with explicit list excluding web_search, copilot_spaces, copilot, stargazers, and git toolsets. Remove X-MCP-Insiders header. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
d261138 to
e1c0660
Compare
Summary
X-MCP-Toolsets: "all"with an explicit list of 17 toolsets, excludingweb_search,copilot_spaces,copilot,stargazers, andgitX-MCP-Insiders: "true"headerChanges
github/.mcp.jsonX-MCP-Toolsetsfrom"all"to explicit comma-separated list of enabled toolsetsX-MCP-Insidersheader entirelygithub/.claude-plugin/plugin.jsonVerification
claude plugin validate ./githubpasses🤖 Generated with Claude Code
Summary by CodeRabbit
Documentation
Chores