feat: add rh-dataverse plugin with rover-people skill - #44
Conversation
Add Red Hat Dataverse MCP server plugin with a skill for looking up employees, managers, direct reports, and org structure via the RoverPeople data product. Assisted-by: Claude:claude-opus-4-6
📝 WalkthroughWalkthroughThis PR registers a new MCP server plugin called Changesrh-dataverse Plugin Registration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
rh-dataverse/skills/rover-people/SKILL.md (1)
51-53: ⚡ Quick winReduce repetitive sentence structure.
Three consecutive sentences begin with "Present" (lines 51–53). Consider rewording to improve readability and avoid monotonous pacing.
♻️ Proposed fix
## Formatting Results -Present single-person results as a card (name, email, title, manager, geo, -cost center). Present multi-person results as a markdown table. Present org -chart results as an indented hierarchy. +For single-person results, use a card format (name, email, title, manager, geo, +cost center). For multi-person results, use a Markdown table. For org +chart results, use an indented hierarchy.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@rh-dataverse/skills/rover-people/SKILL.md` around lines 51 - 53, The three consecutive sentences in SKILL.md that begin with "Present" (the lines describing single-person, multi-person, and org chart results) are repetitive; reword them to vary sentence openings and improve flow—e.g., combine into one sentence or start subsequent sentences with alternatives like "For single-person results, show...", "For multiple people, render...", and "For org charts, display..."; update the three result-description sentences in SKILL.md accordingly to keep the same content but reduce the repeated "Present" wording.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@rh-dataverse/skills/rover-people/SKILL.md`:
- Line 52: In SKILL.md update the phrase "Present multi-person results as a
markdown table." to use the capitalized form "Markdown" (i.e., "Present
multi-person results as a Markdown table.") to follow proper noun
capitalization; locate the exact sentence in SKILL.md and replace "markdown"
with "Markdown".
---
Nitpick comments:
In `@rh-dataverse/skills/rover-people/SKILL.md`:
- Around line 51-53: The three consecutive sentences in SKILL.md that begin with
"Present" (the lines describing single-person, multi-person, and org chart
results) are repetitive; reword them to vary sentence openings and improve
flow—e.g., combine into one sentence or start subsequent sentences with
alternatives like "For single-person results, show...", "For multiple people,
render...", and "For org charts, display..."; update the three
result-description sentences in SKILL.md accordingly to keep the same content
but reduce the repeated "Present" wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 692ad1d2-59e0-46a1-92fc-c6a6f97cfd23
📒 Files selected for processing (6)
.claude-plugin/marketplace.jsonREADME.mdrh-dataverse/.claude-plugin/plugin.jsonrh-dataverse/.mcp.jsonrh-dataverse/README.mdrh-dataverse/skills/rover-people/SKILL.md
| ## Formatting Results | ||
|
|
||
| Present single-person results as a card (name, email, title, manager, geo, | ||
| cost center). Present multi-person results as a markdown table. Present org |
There was a problem hiding this comment.
Capitalize "markdown" as a proper noun in technical writing.
Per LanguageTool, the word "Markdown" should be capitalized when used as a language/format name.
✏️ Proposed fix
Present multi-person results as a markdown table. Present org
+Present multi-person results as a Markdown table. Present org🧰 Tools
🪛 LanguageTool
[uncategorized] ~52-~52: Did you mean the formatting language “Markdown” (= proper noun)?
Context: ...ter). Present multi-person results as a markdown table. Present org chart results as an ...
(MARKDOWN_NNP)
[style] ~52-~52: Three successive sentences begin with the same word. Consider rewording the sentence or use a thesaurus to find a synonym.
Context: ...lti-person results as a markdown table. Present org chart results as an indented hierar...
(ENGLISH_WORD_REPEAT_BEGINNING_RULE)
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@rh-dataverse/skills/rover-people/SKILL.md` at line 52, In SKILL.md update the
phrase "Present multi-person results as a markdown table." to use the
capitalized form "Markdown" (i.e., "Present multi-person results as a Markdown
table.") to follow proper noun capitalization; locate the exact sentence in
SKILL.md and replace "markdown" with "Markdown".
Source: Linters/SAST tools
1 participant
Summary
mcp.dataverse.redhat.com)rover-peopleskill for looking up employees, managers, direct reports, and org structure via the RoverPeople data productTest plan
claude plugin validate .passesclaude plugin validate ./rh-dataversepassesnpx markdownlint-cli2passes onrh-dataverse/**/*.mduvx skillsaw --strictpasses/rh-dataverse:rover-peopletriggers and runs the 3-step pipeline successfullySummary by CodeRabbit
rover-peopleskill for querying people data with structured result formatting options (person cards, tables, and organizational hierarchies).