feat(pr-review-toolkit): warn when posting to resolved threads - #79
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe plugin version changes from 1.12.0 to 1.12.1. Review overlap data now tracks resolved-thread state, updates overlap classification, and exposes warnings and revised approval options for resolved-thread replies. ChangesReview workflow updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
Adds resolved-thread awareness to the PR review preview and bumps the plugin patch version.
Changes:
- Warns when replies target resolved threads.
- Offers conversion to new line comments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
SKILL.md |
Adds warning and conversion instructions. |
plugin.json |
Bumps version to 1.12.1. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pr-review-toolkit/skills/review-pr/SKILL.md`:
- Around line 293-294: Expand the “Convert resolved-thread replies to new line
comments” option in the post-selection flow to state that affected replies are
converted into new line comments, the preview is regenerated with updated
destinations, and approval is requested again before posting. Define the
pending-review state transition so the menu action does not leave the workflow
ambiguous.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 590c6072-2b2e-4f63-acf7-e7a18759a0b0
📒 Files selected for processing (2)
pr-review-toolkit/.claude-plugin/plugin.jsonpr-review-toolkit/skills/review-pr/SKILL.md
cblecker
force-pushed
the
fix/pr-review-resolved-thread-warning
branch
from
July 14, 2026 18:57
85c04cc to
ea5437e
Compare
cblecker
force-pushed
the
fix/pr-review-resolved-thread-warning
branch
from
July 14, 2026 19:21
ea5437e to
af8f6c4
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@pr-review-toolkit/skills/review-pr/review-pr.js`:
- Around line 835-846: The early-return branch in inferThreadOverlap must
synchronize isResolved for existing overlaps. When existing.status is active and
a threadId or commentId is present, find the matching entry in threads, merge
its commentId and resolved state into the returned overlap, and default
isResolved to false when no match exists; preserve the existing result when no
identifiers are available.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 5238c6b5-4c83-44e0-b736-48e9adb3dfcc
📒 Files selected for processing (3)
pr-review-toolkit/.claude-plugin/plugin.jsonpr-review-toolkit/skills/review-pr/SKILL.mdpr-review-toolkit/skills/review-pr/review-pr.js
🚧 Files skipped from review as they are similar to previous changes (2)
- pr-review-toolkit/.claude-plugin/plugin.json
- pr-review-toolkit/skills/review-pr/SKILL.md
Replies to resolved GitHub threads stay collapsed, so the PR author likely won't see them. Add a warning in the preview step and an option to convert those replies to new line comments instead. Assisted-by: Claude:claude-opus-4-6
cblecker
force-pushed
the
fix/pr-review-resolved-thread-warning
branch
from
July 14, 2026 20:01
af8f6c4 to
a9e1a5a
Compare
Owner
Author
|
@CodeRabbit review |
✅ Action performedReview finished.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
AskUserQuestionso the reviewer can switch those findings to the pending-review flow insteadTest plan
Summary by CodeRabbit
New Features
Bug Fixes
Chores