Update delete prefer #38
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to work with database and test with postman
LehruAngela
suggested changes
Aug 29, 2018
| return Response(json.dumps(['Question not Found']), | ||
| status=404, mimetype='application/json') | ||
| return jsonify({f'Question {questionId}': 'Has not been added yet'}), 404 | ||
| return jsonify({f'Question {questionId}': 'Has not been added yet'}), 200 |
There was a problem hiding this comment.
This return message could be improved to "there are no questions or question doesn't exist" since its "if" statement is to query and check if there are any questions in the database.
| 'topic': question[1], | ||
| 'body': question[2] | ||
| } | ||
| return jsonify(temp), 200 |
There was a problem hiding this comment.
the returned json should come with the all answers provided so far for the question according to the notes in the doc.
Owner
Author
There was a problem hiding this comment.
Thanks, I implemented that in a new connection branch, about to send a PR
| request_data = request.get_json() | ||
| if (valid_question(request_data)): | ||
| print(request_data) | ||
|
|
|
|
||
| def valid_question(questionObject): | ||
| if 'topic' in questionObject and 'body' in questionObject: | ||
| if 'topic' in questionObject.keys() and 'body' in questionObject.keys(): |
There was a problem hiding this comment.
You can shift these validator functions to a different file and import them to use them in the views so that the routes.py has routes only
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, please review my PR.
I implemented all the feedback you gave, just left with Documenting and writing the Proper tests.
thanks.