Skip to content

replace the use of SafeConfigParser with bogstandard ConfigParser (and use direct import of configparser, not via six anymore)#20

Merged
valeriupredoi merged 2 commits into
cedadev:masterfrom
valeriupredoi:retire_SafeConfigParser
Nov 13, 2023
Merged

replace the use of SafeConfigParser with bogstandard ConfigParser (and use direct import of configparser, not via six anymore)#20
valeriupredoi merged 2 commits into
cedadev:masterfrom
valeriupredoi:retire_SafeConfigParser

Conversation

@valeriupredoi

Copy link
Copy Markdown
Collaborator

Closes #19

Hi Phil, please see my proposed change from the now completely retired SafeConfigParser in Python=3.12 to the bogstandard ConfigParser - I also removed the import via six even though I think Py2 functionality is still there via the checks for Py2 string types - but, if I was you, I'd remove that altogether and just support Py3 🍺

@valeriupredoi valeriupredoi changed the title replace use SafeConfigParser with bogstandard ConfigParser *and use direct import of configparser, not via six) replace the use of SafeConfigParser with bogstandard ConfigParser (and use direct import of configparser, not via six anymore) Nov 1, 2023
@valeriupredoi

Copy link
Copy Markdown
Collaborator Author

merging this would be great since I'd like to speed up the modernization process - include a Github Action that runs the test, and another one that builds the PyPI package, many thanks to @agstephens for allowing me maintainer rights 👍 - as I see there is literally no activity in the past years, I'll just go ahead and merge it myself, my apologies if this is unethical, but I can always fix whatever may be broken 😁

@alaniwi

alaniwi commented Nov 20, 2023

Copy link
Copy Markdown

I tried running the client (both python and command-line interfaces) with slcs.jasmin.ac.uk and this works successfully.

I also tried it with slcs.ceda.ac.uk and get some certificate verification issues that are wholly independent of this PR and which also exist in ab7f2cc (the earlier commit), so I'll discuss those elsewhere but there is no sign that anything client-side is responsible for that.

So looks okay to me. I am guessing that we don't care about Python 2 support at this stage.

@valeriupredoi One minor thing, you have left a reference to SafeConfigParser in a docstring. See

'''Subclass the SafeConfigParser - to preserve the original string case of

@valeriupredoi

Copy link
Copy Markdown
Collaborator Author

brilliant, very many thanks for checking @alaniwi 🍺 I'll remove that bit of docstring in a cleanup PR - hopefully @philipkershaw could give me maintainer rights on the PyPI project soon, so we can have us a new release 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error importing from myproxy.client import MyProxyClient with Python=3.12 due to SafeConfigParser being completely retired

2 participants