replace the use of SafeConfigParser with bogstandard ConfigParser (and use direct import of configparser, not via six anymore)#20
Conversation
SafeConfigParser with bogstandard ConfigParser *and use direct import of configparser, not via six)SafeConfigParser with bogstandard ConfigParser (and use direct import of configparser, not via six anymore)
|
merging this would be great since I'd like to speed up the modernization process - include a Github Action that runs the test, and another one that builds the PyPI package, many thanks to @agstephens for allowing me maintainer rights 👍 - as I see there is literally no activity in the past years, I'll just go ahead and merge it myself, my apologies if this is unethical, but I can always fix whatever may be broken 😁 |
|
I tried running the client (both python and command-line interfaces) with I also tried it with So looks okay to me. I am guessing that we don't care about Python 2 support at this stage. @valeriupredoi One minor thing, you have left a reference to SafeConfigParser in a docstring. See |
|
brilliant, very many thanks for checking @alaniwi 🍺 I'll remove that bit of docstring in a cleanup PR - hopefully @philipkershaw could give me maintainer rights on the PyPI project soon, so we can have us a new release 👍 |
Closes #19
Hi Phil, please see my proposed change from the now completely retired
SafeConfigParserin Python=3.12 to the bogstandardConfigParser- I also removed the import viasixeven though I think Py2 functionality is still there via the checks for Py2 string types - but, if I was you, I'd remove that altogether and just support Py3 🍺