Skip to content

Fix constant folding to work with list provided as an identifier#199

Merged
copybara-service[bot] merged 1 commit into
cel-expr:mainfrom
l46kok:fix-const-fold-with-list
Dec 21, 2023
Merged

Fix constant folding to work with list provided as an identifier#199
copybara-service[bot] merged 1 commit into
cel-expr:mainfrom
l46kok:fix-const-fold-with-list

Conversation

@l46kok

@l46kok l46kok commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator

Fixes #198

@TristonianJones TristonianJones left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find. Does the same issue exist in Go also?

@l46kok

l46kok commented Dec 21, 2023

Copy link
Copy Markdown
Collaborator Author

I checked, go already has a similar guard

@l46kok l46kok added the ready to pull Pulls the pending PR into Critique label Dec 21, 2023
@copybara-service copybara-service Bot merged commit d76c341 into cel-expr:main Dec 21, 2023
@l46kok l46kok deleted the fix-const-fold-with-list branch December 21, 2023 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready to pull Pulls the pending PR into Critique

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ConstantFoldingOptimizer fails when optimizing "in" operator over non-literal list

2 participants