Add a SubexpressionOptimizer baseline test case for fully extractable presence tests#287
Merged
Merged
Conversation
copybara-service
Bot
force-pushed
the
test_622036697
branch
2 times, most recently
from
835badc to
84228c0
Compare
… presence tests
Note that this isn't actually rewriting the AST in the most optimized form.
Example: `has({'a': true}.a) && has({'a': true}.a)` should rewrite to:
`cel.@block([has({'a': true}.a)], @index0 && @index0`)., not
`cel.@block([{"a": true}], has(@index0.a) && has(@index0.a))`.
This will be addressed with the incoming mutable AST enhancements.
PiperOrigin-RevId: 622240518
copybara-service
Bot
force-pushed
the
test_622036697
branch
from
84228c0 to
432a954
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a SubexpressionOptimizer baseline test case for fully extractable presence tests
Note that this isn't actually rewriting the AST in the most optimized form.
Example:
has({'a': true}.a) && has({'a': true}.a)should rewrite to:cel.@block([has({'a': true}.a)], @index0 && @index0)., notcel.@block([{"a": true}], has(@index0.a) && has(@index0.a)).This will be addressed with the incoming mutable AST enhancements.