ability to share default registry#9
ability to share default registry#9rghetia merged 3 commits intocensus-ecosystem:masterfrom apesternikov:master
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
I signed it |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
Any chance to have this reviewed? |
rghetia
left a comment
There was a problem hiding this comment.
Overall looks good. couple of nits.
prometheus_test.go
Outdated
| t.Fatalf("failed to create views: %v", err) | ||
| } | ||
| defer view.Unregister(v) | ||
| view.SetReportingPeriod(time.Millisecond) |
There was a problem hiding this comment.
since prometheus exporter is using new metricexport.Reader interface it simply reads when request is made to /metrics endpoint. So setting reporting period is not necessary. This was required before when Oc library used to push metrics to prometheus exporter.
prometheus_test.go
Outdated
| var output string | ||
| for { | ||
| time.Sleep(10 * time.Millisecond) | ||
| if i == 1000 { |
There was a problem hiding this comment.
nit: may be 10 is sufficient to declare it failed. Oc counter should be available right away. Not sure about Prometheus counter though.
There was a problem hiding this comment.
Thank you for your review. All updates are done, please take a look.
Fixes #8