Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Run integration tests with different permutations of dependencies. #202

Open
brianquinlan wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Run integration tests with different permutations of dependencies. #202

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6b6c114
Run integration tests with different permuations of dependencies.
brianquinlan Jun 6, 2018
bf35e44
Merge branch 'master' into master
brianquinlan Jun 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion nox.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ def unit(session, py):
session.interpreter = 'python{}'.format(py)

# Install all test dependencies, then install this package in-place.
session.install('google-cloud-trace')
Copy link
Copy Markdown
Contributor

@liyanhui1228 liyanhui1228 Jun 6, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to run unit tests against the latest version of google-cloud-trace? While this can make sure our library works well with the latest release version of it, but it would be confusing whether the tests failed because of the version incompatibility issue or the tested code itself.

I would suggest we pin the version used for tests and add tooling for ensuring we work well with the latest release when the tools is built.

Copy link
Copy Markdown
Contributor Author

@brianquinlan brianquinlan Jun 7, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pin the version or test with the versions matching setup.py i.e.
google-cloud-trace=0.17.0, google-cloud-trace<0.20
google-api-core = 0.1.1, google-api-color < 2.0.0
?

session.install('-r', 'requirements-test.txt')

session.install('-e', '.')
Expand All @@ -47,7 +48,9 @@ def unit(session, py):

@nox.session
@nox.parametrize('py', ['2.7', '3.6'])
def system(session, py):
@nox.parametrize('apicore', ['google-api-core==0.1.1', 'google-api-core==1.0.0', 'google-api-core'])
@nox.parametrize('cloudtrace', ['google-cloud-trace==0.17', 'google-cloud-trace'])
def system(session, py, apicore, cloudtrace):
"""Run the system test suite."""

# Sanity check: Only run system tests if the environment variable is set.
Expand All @@ -62,6 +65,8 @@ def system(session, py):

# Install all test dependencies, then install this package into the
# virutalenv's dist-packages.
session.install(apicore)
session.install(cloudtrace)
session.install('-r', 'requirements-test.txt')
session.install('.')

Expand Down
1 change: 0 additions & 1 deletion requirements-test.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
Django==1.11.7
Flask==0.12.2
google-cloud-monitoring==0.29.0
google-cloud-trace==0.17.0
grpcio==1.8.3
mock==2.0.0
mysql-connector==2.1.6
Expand Down