This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Add stats and metrics reprs#479
Merged
c24t merged 2 commits intocensus-instrumentation:masterfrom Feb 5, 2019
Merged
Conversation
reyang
approved these changes
Jan 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
__repr__methods for a few stats and metrics classes in the style of @reyang's changes in #259.Not all reprs include all the attributes of the class, and in general don't allow the user to reconstruct the object by
evaling it. I'd prefer for reprs to be short and human-readable, and not an exhaustive description of the object, but this is potentially confusing if the user doesn't realize that not every attribute is reflected in the repr. I'm interested to hear other reviewers' opinions.This PR doesn't include reprs for all classes, just ones that were helpful while writing #476. If you agree with this style we can add reprs to new objects going forward.