This repository was archived by the owner on Sep 17, 2025. It is now read-only.
opencensus-ext-django - support all versions of django 1.11#674
Merged
reyang merged 1 commit intocensus-instrumentation:masterfrom Jun 4, 2019
rib3:django-1.11-all-versions
Merged
opencensus-ext-django - support all versions of django 1.11#674reyang merged 1 commit intocensus-instrumentation:masterfrom rib3:django-1.11-all-versions
reyang merged 1 commit intocensus-instrumentation:masterfrom
rib3:django-1.11-all-versions
Conversation
Contributor
Author
|
I tweaked the comparison since it appears that distutils handles alpha,beta,rc safely when specifying patch version numbers include_package_data=True,
long_description=open('README.rst').read(),
install_requires=[
- 'Django >= 1.11.0, < 1.12',
+ 'Django >= 1.11.0, < 1.12.0',
'opencensus >= 0.7.dev0, < 1.0.0',
],
extras_require={},from distutils.version import LooseVersion
In [1]: from distutils.version import LooseVersion
In [2]: LooseVersion('1.12rc1') < LooseVersion('1.12.0')
Out[2]: False
In [3]: LooseVersion('1.12alpha1') < LooseVersion('1.12.0')
Out[3]: False
In [4]: LooseVersion('1.12beta1') < LooseVersion('1.12.0')
Out[4]: False |
Contributor
|
@rib3 Thanks for the fix! @zoidbergwill FYI since it is related with #358. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
opencensus-ext-django: Support all releases of django 1.111.11.21 was just released, which is not compatible with the current install_requires
https://www.djangoproject.com/weblog/2019/jun/03/security-releases/