Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

opencensus-ext-django - support all versions of django 1.11#674

Merged
reyang merged 1 commit intocensus-instrumentation:masterfrom
rib3:django-1.11-all-versions
Jun 4, 2019
Merged

opencensus-ext-django - support all versions of django 1.11#674
reyang merged 1 commit intocensus-instrumentation:masterfrom
rib3:django-1.11-all-versions

Conversation

@rib3
Copy link
Copy Markdown
Contributor

@rib3 rib3 commented Jun 3, 2019

opencensus-ext-django: Support all releases of django 1.11

1.11.21 was just released, which is not compatible with the current install_requires
https://www.djangoproject.com/weblog/2019/jun/03/security-releases/

@rib3 rib3 requested review from a team, c24t, reyang and songy23 as code owners June 3, 2019 21:35
Copy link
Copy Markdown
Contributor

@songy23 songy23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rib3
Copy link
Copy Markdown
Contributor Author

rib3 commented Jun 3, 2019

I tweaked the comparison since it appears that distutils handles alpha,beta,rc safely when specifying patch version numbers

     include_package_data=True,
     long_description=open('README.rst').read(),
     install_requires=[
-        'Django >= 1.11.0, < 1.12',
+        'Django >= 1.11.0, < 1.12.0',
         'opencensus >= 0.7.dev0, < 1.0.0',
     ],
     extras_require={},
from distutils.version import LooseVersion
In [1]: from distutils.version import LooseVersion

In [2]: LooseVersion('1.12rc1') < LooseVersion('1.12.0')
Out[2]: False

In [3]: LooseVersion('1.12alpha1') < LooseVersion('1.12.0')
Out[3]: False

In [4]: LooseVersion('1.12beta1') < LooseVersion('1.12.0')
Out[4]: False

@reyang
Copy link
Copy Markdown
Contributor

reyang commented Jun 4, 2019

@rib3 Thanks for the fix!

@zoidbergwill FYI since it is related with #358.

@reyang reyang merged commit d632e19 into census-instrumentation:master Jun 4, 2019
@rib3 rib3 deleted the django-1.11-all-versions branch June 5, 2019 03:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants