Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

Prepare for 0.7.0 release#739

Merged
reyang merged 3 commits intocensus-instrumentation:v0.7.xfrom
lzchen:release
Jul 31, 2019
Merged

Prepare for 0.7.0 release#739
reyang merged 3 commits intocensus-instrumentation:v0.7.xfrom
lzchen:release

Conversation

@lzchen
Copy link
Copy Markdown
Contributor

@lzchen lzchen commented Jul 31, 2019

Updates all versions of all packages to v0.7.0.

Updates necessary CHANGELOGs.

@lzchen lzchen requested review from a team, c24t, reyang and songy23 as code owners July 31, 2019 21:11
lzchen
lzchen commented Jul 31, 2019
View reviewed changes
context/opencensus-context/CHANGELOG.md

## 0.7.0
Released 2019-07-31

Copy link
Copy Markdown
Contributor Author

@lzchen lzchen Jul 31, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was wondering if we should put "-version update" under the notes for all packages that did not have changes or leave it as blank?

Copy link
Copy Markdown
Contributor

@reyang reyang Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have strong opinion, personally I would probably put "bumped version" here.

Copy link
Copy Markdown
Contributor Author

@lzchen lzchen Jul 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, seeing an empty space is awkward. I will make the change.

reyang
reyang approved these changes Jul 31, 2019
View reviewed changes
Copy link
Copy Markdown
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@reyang reyang merged commit fa0816e into census-instrumentation:v0.7.x Jul 31, 2019
@c24t
Copy link
Copy Markdown
Member

c24t commented Aug 1, 2019

Does it make sense to release updates to a bunch of packages without any code changes?

@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Aug 1, 2019

@c24t
You bring up a good point. However, the main concern with having multiple different versions per package is that it's very difficult to maintain as contributors and complicated to debug as users. If the versions for all the packages are changed sooner than later, the better time we will have maintaining the code.

@c24t
Copy link
Copy Markdown
Member

c24t commented Aug 1, 2019

LGTM if it doesn't include version updates for packages that haven't changed and don't rely on changes in dependencies.

@lzchen
Copy link
Copy Markdown
Contributor Author

lzchen commented Aug 1, 2019

Fixed in [#741]

lzchen added a commit that referenced this pull request Aug 1, 2019
@lzchen
Bump version and Merge Changelog after 0.7.0 release (#740)
dfd6d4f 
* Prepare for 0.7.0 release (#739)

* Bump version to 0.7.0 for only packages that have changed (#741)

* bump version

* fix typos
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@c24t c24t Awaiting requested review from c24t

2 more reviewers

@songy23 songy23 songy23 approved these changes

@reyang reyang reyang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lzchen @c24t @songy23 @reyang @googlebot