Skip to content
This repository was archived by the owner on Sep 17, 2025. It is now read-only.

#279 Add new method to set span status.#798

Closed
maeserichar wants to merge 2 commits intocensus-instrumentation:masterfrom
maeserichar:279-setter-for-status
Closed

#279 Add new method to set span status.#798
maeserichar wants to merge 2 commits intocensus-instrumentation:masterfrom
maeserichar:279-setter-for-status

Conversation

@maeserichar
Copy link
Copy Markdown

Just an easy change to avoid needing to import status in order to set the status of a span.

@maeserichar maeserichar requested review from a team, c24t, reyang and songy23 as code owners October 5, 2019 17:32
@googlebot
Copy link
Copy Markdown

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: no and removed cla: yes labels Oct 5, 2019
@maeserichar maeserichar force-pushed the 279-setter-for-status branch from 3b204f1 to 3f33bae Compare October 6, 2019 16:18
@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Oct 6, 2019
@victoraugustolls
Copy link
Copy Markdown
Contributor

This was partially discussed here!

@reyang What do you think?

@lzchen
Copy link
Copy Markdown
Contributor

lzchen commented Oct 9, 2019

With this change, is there a need for the Status class?
What do you think @victoraugustolls @reyang ?

EDIT: Just saw the previous thread, this seems fine. Also, just realized removing Status would be a breaking change.

@victoraugustolls
Copy link
Copy Markdown
Contributor

This seems to me more like a helper method, and I wouldn't remove Status class, as not only it is a breaking change but is referenced in OT spec as mandatory, and it would make the job a lot difficult in the migration in case it was removed.

In my opinion, I would rather have utils method and not add it inside the Span class, but it is a personal view, would wait @reyang for comments.

@reyang
Copy link
Copy Markdown
Contributor

reyang commented Oct 9, 2019

I agree with @victoraugustolls.

@maeserichar
Copy link
Copy Markdown
Author

Great! So something in the line of setSpanStatus(span, code, message, details) in `trace/utils.py' would be more aligned with that?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants