#279 Add new method to set span status.#798
#279 Add new method to set span status.#798maeserichar wants to merge 2 commits intocensus-instrumentation:masterfrom
Conversation
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. ℹ️ Googlers: Go here for more info. |
3b204f1 to
3f33bae
Compare
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
With this change, is there a need for the EDIT: Just saw the previous thread, this seems fine. Also, just realized removing |
|
This seems to me more like a helper method, and I wouldn't remove In my opinion, I would rather have utils method and not add it inside the |
|
I agree with @victoraugustolls. |
|
Great! So something in the line of |
Just an easy change to avoid needing to import status in order to set the status of a span.