This repository was archived by the owner on Sep 17, 2025. It is now read-only.
Fix HTTP attributes for deps, fix success and response/resultCode for Azure Exporter#827
Merged
lzchen merged 20 commits intocensus-instrumentation:masterfrom Jan 28, 2020
Merged
Conversation
lzchen
requested review from
a team,
c24t,
reyang and
songy23
as code owners
Contributor
Author
|
@lmolkova |
lzchen
changed the title
lmolkova
reviewed
Jan 15, 2020
contrib/opencensus-ext-azure/opencensus/ext/azure/trace_exporter/__init__.py
Show resolved
Hide resolved
lmolkova
reviewed
Jan 15, 2020
contrib/opencensus-ext-azure/opencensus/ext/azure/trace_exporter/__init__.py
Show resolved
Hide resolved
Contributor
Author
|
@lmolkova |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address [#825] and [#826], [#831] and [#832]
Adds "component" span attributes to
requestsandhttplibintegrations to specify "http" type.Adds logic to popular success and responseCode based off span status or status_code in span attributes.