Skip to content
This repository was archived by the owner on Nov 7, 2022. It is now read-only.

add resource to vmreceiver#587

Merged
songy23 merged 1 commit intocensus-instrumentation:masterfrom
rghetia:resource
Jun 22, 2019
Merged

add resource to vmreceiver#587
songy23 merged 1 commit intocensus-instrumentation:masterfrom
rghetia:resource

Conversation

@rghetia
Copy link
Copy Markdown
Contributor

@rghetia rghetia commented Jun 21, 2019

porting changes from open-telemetry.
Porting it here because SD exporter is removed from otelsvc in opentelemetry-service (equivalent of OcAgent in opencensus-service.

Copy link
Copy Markdown

@pjanotti pjanotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2019

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files          86       86           
  Lines        5518     5518           
=======================================
  Hits         3665     3665           
  Misses       1645     1645           
  Partials      208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee9655...da7cc89. Read the comment docs.

1 similar comment
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 21, 2019

Codecov Report

Merging #587 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #587   +/-   ##
=======================================
  Coverage   66.41%   66.41%           
=======================================
  Files          86       86           
  Lines        5518     5518           
=======================================
  Hits         3665     3665           
  Misses       1645     1645           
  Partials      208      208

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dee9655...da7cc89. Read the comment docs.

@rghetia
Copy link
Copy Markdown
Contributor Author

rghetia commented Jun 21, 2019

@pjanotti , @songy23 can one of you please merge this? I don't have write access.

@songy23 songy23 merged commit d8a2872 into census-instrumentation:master Jun 22, 2019
@rghetia
Copy link
Copy Markdown
Contributor Author

rghetia commented Jun 25, 2019

@sjkaris can you please release oc-agent with this fix?

@rghetia
Copy link
Copy Markdown
Contributor Author

rghetia commented Jun 26, 2019

@sjkaris friendly reminder to release new version of oc-agent.

@flands flands added this to the 0.1.9 milestone Jun 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants