client: switch AT_NO_ATTR_SYNC to AT_STATX_DONT_SYNC #45844
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vshankar
reviewed
Apr 12, 2022
src/client/Client.cc
Outdated
| { | ||
| unsigned mask = 0; | ||
|
|
||
| /* if NO_ATTR_SYNC is set, then we don't need any -- just use what's in cache */ |
Member
Author
|
Updated it also by fixing the comments in following two files: |
kotreshhr
approved these changes
Apr 18, 2022
Contributor
kotreshhr
left a comment
kotreshhr
left a comment
There was a problem hiding this comment.
nit:typo s/stardard/standard/
Looks good to me otherwise.
Member
Author
Sure, will fix it. Thanks @kotreshhr
|
The glibc has defined its own STATX SYNC related flags: define AT_STATX_SYNC_TYPE 0x6000 define AT_STATX_SYNC_AS_STAT 0x0000 define AT_STATX_FORCE_SYNC 0x2000 define AT_STATX_DONT_SYNC 0x4000 Just switch to use the standard ones. Fixes: https://tracker.ceph.com/issues/55253 Signed-off-by: Xiubo Li <xiubli@redhat.com>
From the posix and the initial statx supporting commit comments, the AT_STATX_DONT_SYNC is a lightweight stat flag and the AT_STATX_FORCE_SYNC is a heaverweight one. And also checked all the other current usage about these two flags they are all doing the same, that is only when the AT_STATX_FORCE_SYNC is not set and the AT_STATX_DONT_SYNC is set will they skip sync retriving the attributes from storage. Fixes: https://tracker.ceph.com/issues/55253 Signed-off-by: Xiubo Li <xiubli@redhat.com>
Member
|
@lxbsz is this ready for qa or are you waiting on something? :) |
Member
Author
Yeah, it's ready to qa. |
Contributor
|
jenkins test make check |
1 similar comment
Contributor
|
jenkins test make check |
vshankar
approved these changes
May 14, 2022
This was referenced Jun 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The glibc has defined its own STATX SYNC related flags:
define AT_STATX_SYNC_TYPE 0x6000
define AT_STATX_SYNC_AS_STAT 0x0000
define AT_STATX_FORCE_SYNC 0x2000
define AT_STATX_DONT_SYNC 0x4000
Just switch to use the stardard ones.
And from the posix and the initial statx supporting commit comments,
the AT_STATX_DONT_SYNC is a lightweight stat flag and the
AT_STATX_FORCE_SYNC is a heaverweight one. And also checked all
the other current usage about these two flags they are all doing
the same, that is only when the AT_STATX_FORCE_SYNC is not set
and the AT_STATX_DONT_SYNC is set will they skip sync retriving
the attributes from storage.
Fixes: https://tracker.ceph.com/issues/55253
Signed-off-by: Xiubo Li xiubli@redhat.com
Checklist
Show available Jenkins commands
jenkins retest this pleasejenkins test classic perfjenkins test crimson perfjenkins test signedjenkins test make checkjenkins test make check arm64jenkins test submodulesjenkins test dashboardjenkins test dashboard cephadmjenkins test apijenkins test docsjenkins render docsjenkins test ceph-volume alljenkins test ceph-volume toxjenkins test windows