Skip to content

Fix some strings left & add translation#4

Merged
certified84 merged 2 commits intocertified84:v0.1.4from
gdonisi:v0.1.4
Feb 22, 2022
Merged

Fix some strings left & add translation#4
certified84 merged 2 commits intocertified84:v0.1.4from
gdonisi:v0.1.4

Conversation

@gdonisi
Copy link
Copy Markdown
Contributor

@gdonisi gdonisi commented Feb 20, 2022

Hi, here's my translation. I've also moved some strings in the strings.xml file. As I said, I'm not very familiar with Kotlin so please review and edit my code if needed :)

Copy link
Copy Markdown
Owner

@certified84 certified84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @gdonisi, I went through these changes and I must say you really did a good job. Lots of hardcoded strings I didn't even pay attention to (especially in the EditNoteFragment). Cheers mate 👍👍👍

Copy link
Copy Markdown
Owner

@certified84 certified84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there @gdonisi, you really did a good job here mate. I don't speak Italian 😂 so I had to use a translator and I must say this was really a job well done. Although some strings didn't translate properly (I thinking it has to do with my translator) but I'll really appreciate you going through the translations again. I'll go ahead and merge this PR. After going through the translations again, if there are any correction, kindly open another PR too. Well done mate 🙌🙌🙌

@certified84 certified84 merged commit 812b04a into certified84:v0.1.4 Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants