Output normalization#1717
Merged
joeyballentine merged 4 commits intochaiNNer-org:mainfrom Apr 7, 2023
Merged
Conversation
joeyballentine
approved these changes
Apr 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the output normalization I recently mentioned on discord. The main change is that
ImageInputno longer normalizes,ImageOutputdoes the normalization instead. This is more efficient because:assume_normalized=True).Only when an image output is not used is the new system less efficient. However, this case is relatively rare and can be made equally efficient with
assume_normalized=Truefor already normalized images. Luckily, this trick can be used for Separate RGBA and Split Transparency.