Upgrade to Navi 0.6.0#2001
Merged
joeyballentine merged 1 commit intochaiNNer-org:mainfrom Jul 28, 2023
Merged
Conversation
Merged
joeyballentine
approved these changes
Jul 28, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
intcasts. The improved arithmetic in 0.6.0 means that Navi doesn't return +-inf anywhere like before.toJson. The function was unused.About how structs changes: Structs kinds were previously differentiated by their name. E.g. the
Imagestruct was a different kind than theColorstruct. Instead of using the name, structs now have a descriptor that identifies the kind. Aside from the name, the descriptor also contains the field names, field definition types, and the default instance of the type (= all fields being the definition type).