color_transfer_node: Avoid RGB contamination by transparent pixels#2389
Merged
joeyballentine merged 6 commits intochaiNNer-org:mainfrom May 8, 2024
Merged
Conversation
RunDevelopment
requested changes
Dec 12, 2023
backend/src/packages/chaiNNer_standard/image_filter/correction/color_transfer.py
Outdated
Show resolved
Hide resolved
Member
|
Sorry for the delay @Splendide-Imaginarius! |
Contributor
Author
|
Thanks for the review @RunDevelopment, I'll look into your suggested changes. |
Contributor
Author
|
Very sorry for letting this PR bitrot for months, I will try to get the feedback resolved soon. |
The Color Transfer node had the same bug as the Average Color Fix bug that was fixed in f4a7dcb. This commit adds a similar fix for Color Transfer.
Splendide-Imaginarius
force-pushed
the
color-transfer-indeterminate
branch
from
fd3a986 to
2b6bbcd
Compare
Contributor
Author
|
@RunDevelopment I think I've addressed all review, what's still needed to get this PR moving forward again? |
Contributor
Author
|
@joeyballentine Is there anything I can do to get this moving? |
Member
|
Sorry, will review soon |
RunDevelopment
approved these changes
May 8, 2024
Member
RunDevelopment
left a comment
RunDevelopment
left a comment
There was a problem hiding this comment.
Sorry for the delay!
Code looks good!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Color Transfer node had the same bug as the Average Color Fix bug that was fixed in #1907.
This commit adds a similar fix for Color Transfer.