Skip to content

Fix load error messages not having a stack trace #2508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeyballentine merged 1 commit into from
Jan 24, 2024
Merged

Fix load error messages not having a stack trace #2508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix load error messages not having a stack trace
  • Loading branch information
@RunDevelopment
RunDevelopment committed Jan 24, 2024
commit 90caf92b421f4a901e80bbfc4af730c9b5f19b23
5 changes: 3 additions & 2 deletions backend/src/server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -572,8 +572,9 @@ async def install_deps(dependencies: list[api.Dependency]):
import_errors: list[api.LoadErrorInfo] = []
for e in load_errors:
if not isinstance(e.error, ModuleNotFoundError):
logger.warning(f"Failed to load {e.module} ({e.file}):")
logger.warning(e.error)
logger.warning(
f"Failed to load {e.module} ({e.file}):", exc_info=e.error
)
else:
import_errors.append(e)

Expand Down