Fixed punctuation in path type tags#2701
Merged
joeyballentine merged 1 commit intochaiNNer-org:mainfrom Mar 21, 2024
Merged
Conversation
joeyballentine
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Path type tags use
direction: rtlto make the ellipsis appear on the left side of the text. However, this is not the only effect ofrtl. It also puts punctuation at the end of a string in front.Example: That path should be
C:\, but we'll see something else:Similarly, it will also put punctuation at the start of the string at the end. This messes with Unix-style paths. The follow is supposed to be
/home/name:My fix for this issue is quite simple: if the path starts or ends with a punctuation character, don't do
direction: rtl. This means that left ellipsis are a windows-only feature now, but that's a small price to pay for correct visuals.With the fix:
