Fixed Saving images with OpenCV#2772
Merged
joeyballentine merged 1 commit intochaiNNer-org:mainfrom Apr 9, 2024
Merged
Conversation
joeyballentine
approved these changes
Apr 9, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #1612, I noticed that save images with OpenCV was broken. I fixed the following:
*) or crash the backend (e.g.%$). I fixed this by using the same code path for both ASCII and non-ASCII file paths.os.renamedoesn't work when the file already exists.The solution for both problems is to (1)
cv2.imencodeand (2) save the buffer with regularopen. This is simple and works correctly. The only issue is that it's a tiny bit slower for very large files, but that's a reasonable price to pay for correctness.I also checked saving images with PIL and the DDS stuff. Both work correctly.