Install FFMPEG using the backend#2799
Merged
joeyballentine merged 6 commits intochaiNNer-org:mainfrom Apr 18, 2024
Merged
Conversation
joeyballentine
approved these changes
Apr 18, 2024
Member
joeyballentine
left a comment
joeyballentine
left a comment
There was a problem hiding this comment.
Code looks good and this works really well. 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the FFMPEG installation into the backend. FFMPEG will now be installed when a video node is used, instead of when chainner is first starting up after a fresh installation.
Since the backend now has to store files, I also added a
storage_dirfield toNodeContext, so nodes can now store files. This storage directory is set as a flag when starting the server. This allows the main electron process to set the storage dir when starting the backend. Since the main process doesn't start the backend innpm run dev, there's also some fallback logic in the backend to use chainner's app data dir.Since
appdirsis no longer used by our nodes, I moved it torequirements.txtto make it a dev dependency.I also cleaned up the initialization of our
AppContextclasses a little.Fixes #2271