#1525 add avif support#2820
Merged
joeyballentine merged 2 commits intochaiNNer-org:mainfrom Apr 26, 2024
Merged
Conversation
Member
|
Thanks for this addition! Could you please format your code changes with ruff? |
Contributor
Author
Done. I had to add |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for loading and saving images in the AVIF format, using
pillow-avif-pluginas suggested in #1525.There are tons of potential options that could be added to the save node for AVIF (see options from libavif and options exposed by pillow-avif-plugin). I kept things to a minimum and only exposed quality and subsampling. Notably, the lossless option is missing since
pillow-avif-plugindoesn't expose it. I've read that AVIF lossless isn't that great at reducing file sizes anyway, but I'm not sure how true that is.Also, I made some guesses when working with
with_idandif_enum_group, please let me know if those magic numbers need any corrections.