Use atexit to always kill worker#2822
Merged
joeyballentine merged 1 commit intochaiNNer-org:mainfrom Apr 27, 2024
Merged
Conversation
joeyballentine
approved these changes
Apr 27, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just for fun, I asked chatGPT about our problem with the worker process being orphaned when the host process was killed. It suggested using
atexit, which I thought was a good idea. We already solved the problem using the/shutdownendpoint, but I think it's good to useatexitas a backup.I also think that we should keep
/shutdown. It's useful to have because it allows the server to refuse to be shutdown, in case we need this ability in the future.