Skip to content

#2654 add custom tiling option#2828

Merged
joeyballentine merged 7 commits intochaiNNer-org:mainfrom
the-database:2654-custom-tiling
Apr 29, 2024
Merged

#2654 add custom tiling option#2828
joeyballentine merged 7 commits intochaiNNer-org:mainfrom
the-database:2654-custom-tiling

Conversation

@the-database
Copy link
Contributor

Adds a custom option to the tile size dropdown to allow entering any tile size.

@the-database
Copy link
Contributor Author

the-database commented Apr 28, 2024

Working on the pyright errors. EDIT: resolved.

Copy link
Member

@joeyballentine joeyballentine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! Just one minor nit

@joeyballentine
Copy link
Member

I think you just need to make it so the check is TileSize(custom_tile_size) if tile_size == CUSTOM and custom_tile_size is not None else tile_size,

@the-database
Copy link
Contributor Author

I think you just need to make it so the check is TileSize(custom_tile_size) if tile_size == CUSTOM and custom_tile_size is not None else tile_size,

Done, thanks!

@joeyballentine
Copy link
Member

Thanks again. I very much appreciate the contributions

@joeyballentine joeyballentine merged commit f971974 into chaiNNer-org:main Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants